Manchester | 26-ITP-Jan | khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite #1270
Closed
khalidbih wants to merge 11 commits intoCodeYourFuture:mainfrom
Closed
Manchester | 26-ITP-Jan | khalidbih | Sprint 3 | coursework/sprint-3-implement-and-rewrite #1270khalidbih wants to merge 11 commits intoCodeYourFuture:mainfrom
khalidbih wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
khalidbih
added
📅 Sprint 3
Author
|
Hi @cjyuan, I’ve created a new PR, and there are no merge conflicts now. |
cjyuan
reviewed
Mar 16, 2026
Comment on lines
+14
to
+16
| test("should return true when absolute numerator is less than absolute denominator", () => { | ||
| expect(isProperFraction(-4, 7)).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
We can use pseudo-code or notations such as abs(...) or |...|, and < in the description to make it more concise. For example,
test("should return true when abs(numerator) < abs(denominator)", () => {
expect(isProperFraction(-4, 7)).toEqual(true);
... // Test all combination of positive/negative numerator and denominator.
});
Author
There was a problem hiding this comment.
I updated the test description.
cjyuan
added
Reviewed
khalidbih
added
Needs Review
cjyuan
reviewed
Mar 17, 2026
Comment on lines
+20
to
+25
| test("should return true when numerator < denominator and denominator is negative", () => { | ||
| expect(isProperFraction(4, -7)).toEqual(true); | ||
| }); | ||
| test("should return true when numerator and denominator are both negative and numerator < denominator", () => { | ||
| expect(isProperFraction(-4, -7)).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could also use the absolute value notation on these descriptions.
In math, 4 is larger than -7, and -4 is larger than -7. The absolute value notation could help make the description concise.
Author
There was a problem hiding this comment.
Thank you for the suggestion, I’ll keep this in mind for future tests.
cjyuan
added
Complete
Author
Thank you for all your feedback and guidance. |
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist :
Changelist :
I have completed the coursework/sprint-3-implement-and-rewrite.